Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct compilation with COMPASS_CAL_ENABLED off #25017

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Correct compilation with COMPASS_CAL_ENABLED off #25017

merged 3 commits into from
Sep 19, 2023

Conversation

peterbarker
Copy link
Contributor

This define refers only to the tumbling sort of cal, but we were putting large-vehicle-cal in too.

RC_Channels was also ignoring this define.

Board               AP_Periph  blimp  bootloader  copter  heli  iofirmware  plane  rover  sub
Durandal                       *      *           *       *                 *      *      *
HerePro             *                                                                     
Hitec-Airspeed      *                                                                     
KakuteH7-bdshot                *      *           *       *                 *      *      *
MatekF405                      *      *           *       *                 *      *      *
Pixhawk1-1M-bdshot             *                  *       *                 *      *      *
f103-QiotekPeriph   *                                                                     
f303-Universal      *                                                                     
iomcu                                                           *                         
revo-mini                      *      *           *       *                 *      *      *
skyviper-v2450                                    *

... and with it disabled in this PR's branch:

Board               AP_Periph  blimp   bootloader  copter  heli    iofirmware  plane   rover   sub
CubeOrange                     -14368  *           -14352  -14328              -14288  -14336  -14312
Durandal                       -14424  *           -14400  -14384              -14344  -14392  -14360
HerePro             *                                                                          
Hitec-Airspeed      *                                                                          
KakuteH7-bdshot                -12496  *           -12456  -12472              -12552  -12448  -12528
MatekF405                      -12496  *           -12432  -12424              -12184  -12512  -12512
Pixhawk1-1M-bdshot             -12400              -12376  -12360              -12408  -12384  -12472
f103-QiotekPeriph   *                                                                          
f303-Universal      *                                                                          
iomcu                                                              *                           
revo-mini                      -12520  *           -12520  -12560              -12544  -12472  -12416
skyviper-v2450                                     -12440

@peterbarker peterbarker merged commit 164b732 into ArduPilot:master Sep 19, 2023
84 checks passed
@peterbarker peterbarker deleted the pr/compass-cal-compilation-fix branch September 19, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge approved these changes

Assignees
No one assigned
Labels
MergeOnCIPass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterbarker @tridge @CraigElder